Repository navigation
Chore: Move the window pin to 7c7a907 (#563, #18) - #685
Merged
Merged
Conversation
fcb96ea never had its own fork CI run (superseded by #207), so the pin goes to 7c7a907: fork #209 (macOS types each key once), #205 and #210 (Linux scale from Xft.dpi, GNOME text scale once), #206 (no stretched present on Windows), #207 (native view slot; both macOS windows follow a backing-scale change). linux-native-window.test.sh now expects the configure event to measure at the window's scale, which #205 reads from Xft.dpi instead of a constant.
b-re-w
marked this pull request as ready for review
November 13, 2026 06:43
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #563
Refs #18
WINDOW_REVISION moves to fork 7c7a907631c (fcb96ea had no fork CI run of its own; p1B: take 7c7a907): #209 fixes every typed character being inserted twice on the Kotlin/Native macOS window (#563), #205 and #210 make both Linux windows scale with Xft.dpi and apply the GNOME text scale once, #206 skips a stretched present when ResizeBuffers fails on Windows, #207 adds the native view slot (FR-81) and makes both macOS windows follow a backing-scale change (FR-82). linux-native-window.test.sh follows #205 (scale instead of a constant). Every scripts/tests/*.test.sh passes.
p19 verifies #563 by typing on a Mac after this lands.
Verified
Fork 7c7a907631c (go from p1B, leader decision): windows-shared, graalvm windows/linux, Linux window (first compile of #205/#210), scene, desktop tests and window publish green; the macOS window/common jobs wait for org macOS runners, so macOS rests on the fork's local runs (macos 103/0, scene 97/0) and the local builder here: ./kotlin test -m macos 45/45, ./kotlin test -m desktop 1015/1015. Every scripts/tests/*.test.sh passes.